Bug 88524

Summary:

check-webkit-style needs to be taught about <public/Foo.h>

Product:

WebKit

Reporter:

Kinuko Yasuda <kinuko>

Component:

Tools / Tests

Assignee:

Kinuko Yasuda <kinuko>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, levin, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	levin: review+

Description Kinuko Yasuda 2012-06-07 04:37:17 PDT

Currently check-webkit-style considers any headers included with <> (i.e. is_system==True) as non-primary headers, but some platform implementation includes its primary header placed under Platform/.../public with <>.  check-webkit-style warns include_order for those files.

Examples:
Source/WebCore/platform/chromium/support/WebHTTPBody.cpp
Source/WebCore/platform/chromium/support/WebHTTPLoadInfo.cpp
Source/WebCore/platform/chromium/support/WebURL.cpp
Source/WebCore/platform/chromium/support/WebURLError.cpp
Source/WebCore/platform/chromium/support/WebURLRequest.cpp
Source/WebCore/platform/chromium/support/WebURLResponse.cpp

Running check-webkit-style on any of these files generates include_order error:
Source/WebCore/platform/chromium/support/WebHTTPBody.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]

Comment 1 Kinuko Yasuda 2012-06-07 04:41:04 PDT

Created attachment 146253 [details]
Patch

Comment 2 Kinuko Yasuda 2012-06-07 21:24:41 PDT

Committed r119794: <http://trac.webkit.org/changeset/119794>