Summary: | 2 math sputnik test fail on 32 bit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
Component: | JavaScriptCore | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | allan.jensen, ap, barraclough, commit-queue, ggaren, gyuyoung.kim, jturcotte, mrobinson, oliver, rakuco, zherczeg | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 420+ | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 87008 | ||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-06-07 03:43:27 PDT
Investigated the issue. sin on x87 and SSE2 based libc differs. The test should allow a bigger difference for this test case. What do you think, Alexey? Note: 6.283185307179586 = 2*PI I don't know anything specific about these tests or sin() behavior in JavaScript. Sounds like maybe one cannot use such versions of libc to implement JavaScript then. After calculating a bit on the error I can safely say this is not the standard 80bit vs 64bit precision error. The values we get on 32bit here only have the precision of 32bit float. At some point we must be losing half the precision. If I run the online test262 tests (the successor to sputnik) at http://test262.ecmascript.org/#, I don't get any errors in Chapter 15 even when using a build that fails the Chapter 15 tests in WebKit. So the tests might have been revised or removed, but I haven't been able to find a place to download test262 or read the changelog yet. *** Bug 43568 has been marked as a duplicate of this bug. *** Created attachment 199227 [details]
Patch
Created attachment 199228 [details]
Patch
uploaded unrelated changed
Comment on attachment 199228 [details]
Patch
I'm r+ing it since the test update looks fine, but it seems like we have rarely updated our copy of those tests before.
If Allan can wait a couple of days before landing it, feel free to r- it until then if this isn't the right thing to do.
Looks OK to me. Comment on attachment 199228 [details] Patch Clearing flags on attachment: 199228 Committed r150250: <http://trac.webkit.org/changeset/150250> All reviewed patches have been landed. Closing bug. |