Bug 88510

Summary: Remove JavaScriptCore dependencies from gyp
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Dominic Cooney <dominicc>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dominicc
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch abarth: review+

Ryosuke Niwa
Reported 2012-06-07 00:55:52 PDT
It appears that we don't need to keep track of JavaScriptCore files in gyp since Chromium doesn't support JSC anymore and there doesn't seem to be a strong interest in using gyp as the common build system in other ports.
Attachments
WIP Patch (55.44 KB, patch)
2012-06-08 00:02 PDT, Dominic Cooney 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2012-06-08 00:02:32 PDT
Created attachment 146494 [details] WIP Patch
Dominic Cooney
Comment 2 2012-06-08 00:03:07 PDT
To bake on bots. Drive-by comments welcome.
Adam Barth
Comment 3 2012-06-08 11:09:28 PDT
Comment on attachment 146494 [details] WIP Patch Thanks for cleaning this up. I'm sad we didn't succeed in unifying the build systems, but there isn't a strong need to keep these files around. They'll be in the svn history if we want to find them. You can also remove http://trac.webkit.org/browser/trunk/Source/gyp and http://trac.webkit.org/browser/trunk/Tools/Scripts/generate-project-files .
Dominic Cooney
Comment 4 2012-06-10 06:42:41 PDT
Committed r119921.
Adam Barth
Comment 5 2012-06-10 12:29:31 PDT
Looks like you left behind some empty folders. (You're probably using git.) It would be nice to use svn to delete these empty folders.
Dominic Cooney
Comment 6 2012-06-26 17:49:49 PDT
Pursuing removing the empty folders and removing more files in bug 90029.
Note You need to log in before you can comment on or make changes to this bug.