Bug 88460 – [chromium] Clean up GraphicsContext3D implementation

• Component: New Bugs
• Status: RESOLVED FIXED

[James Robinson]

[chromium] Clean up GraphicsContext3D implementation

[James Robinson]

Created attachment 146123 [details]
Patch

[James Robinson]

Here's some very overdue cleanup.  Diffstat:

 Source/WebKit/chromium/ChangeLog                   |  128 ++
 Source/WebKit/chromium/WebKit.gyp                  |    1 +
 .../WebKit/chromium/src/Extensions3DChromium.cpp   |   56 +-
 .../chromium/src/GraphicsContext3DChromium.cpp     | 1404 +++++---------------
 .../chromium/src/GraphicsContext3DPrivate.cpp      |  379 ++++++
 .../WebKit/chromium/src/GraphicsContext3DPrivate.h |  247 +----
 6 files changed, 855 insertions(+), 1360 deletions(-)


To review, I'd recommend looking at just the right hand side - the diff isn't all that illuminating.

I plan to move the implemenetations into Source/WebCore/platform/chromium/support/ as a followup, but would rather do code changes and file moves in different patches.

[Kenneth Russell]

Comment on attachment 146123 [details]
Patch

Thanks for doing this and deleting so much boilerplate code. Looks great. r=me

[James Robinson]

Thanks for the fast review.  webkit_unit_tests, layout tests, and gpu_tests are all happy with this patch on my box.

[James Robinson]

Committed r119631: <http://trac.webkit.org/changeset/119631>