| Summary: | Teach git about localizable *.strings files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aroben, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
David Kilzer (:ddkilzer)
2012-06-06 13:12:58 PDT
Created attachment 146094 [details]
Patch v1
Attachment 146094 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'.gitattributes', u'ChangeLog']" exit_code: 1
ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 146094 [details]
Patch v1
Love it!
Will this have any effect (good or bad) for generating patches containing changes to these files?
(In reply to comment #3) > (From update of attachment 146094 [details]) > Love it! > > Will this have any effect (good or bad) for generating patches containing changes to these files? It will have the effect of creating a real diff for *.strings files, but developers will have to run the git-config command in order to get the nicer diffs (as was necessary with the ObjC changes). Thanks Adam! Committed r119619: <http://trac.webkit.org/changeset/119619> (In reply to comment #4) > It will have the effect of creating a real diff for *.strings files But will someone else be able to apply that diff to their own tree? |