Bug 88368

Summary: PrettyPatch.rb complains about missing checksum for new pixel results
Product: WebKit Reporter: Tony Chang <tony>
Component: Tools / TestsAssignee: Ojan Vafai <ojan>
Severity: Normal CC: ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch tony: review+

Description Tony Chang 2012-06-05 15:37:09 PDT
Here's an example: https://bugs.webkit.org/attachment.cgi?id=145881&action=review

LayoutTests/platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.png is a new file that has a checksum.
Comment 1 Ojan Vafai 2012-07-13 10:14:23 PDT
Created attachment 152287 [details]
Comment 2 Tony Chang 2012-07-13 10:53:25 PDT
Comment on attachment 152287 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=152287&action=review

> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb:74
> +        # FIXME: This should match, but there's a bug when running the tests where the image data
> +        # doesn't get properly written out the temp files, so we there there is no image and don't print

Missing preposition? "...doesn't get properly written out [to] the temp files..."
Extra 'we there'? "...so /we there/ there is no image..."

> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb:75
> +        # the warning that the image is missing it's checksum.

Comment 3 Ojan Vafai 2012-07-13 11:11:51 PDT
Committed r122607: <http://trac.webkit.org/changeset/122607>