Bug 88351 – Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Emil A Eklund]

Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test to allow for platform differences.

[Emil A Eklund]

Created attachment 145846 [details]
Patch

[Levi Weintraub]

Comment on attachment 145846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145846&action=review

> LayoutTests/ChangeLog:9
> +        Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
> +        test to allow for platform differences.

It makes me a saaaaad panda to see tests go backwards here, but I get it. Perhaps a little more info would be handy?

> LayoutTests/ChangeLog:15
> +        * fast/sub-pixel/float-containing-block-with-margin-expected.html: Removed.
> +        * fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
> +        * fast/sub-pixel/float-containing-block-with-margin-expected.txt: Added.
> +        * fast/sub-pixel/float-containing-block-with-margin.html:
> +        * platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.

Windows?

[Emil A Eklund]

(In reply to comment #2)
> (From update of attachment 145846 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145846&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
> > +        test to allow for platform differences.
> 
> It makes me a saaaaad panda to see tests go backwards here, but I get it. Perhaps a little more info would be handy?

It is unfortunate but the default styles for each platform makes it very hard to write a reftests that works on all.

> Windows?

I'll grab the windows image results from the bots as needed.

[Levi Weintraub]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 145846 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=145846&action=review
> > 
> > > LayoutTests/ChangeLog:9
> > > +        Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
> > > +        test to allow for platform differences.
> > 
> > It makes me a saaaaad panda to see tests go backwards here, but I get it. Perhaps a little more info would be handy?
> 
> It is unfortunate but the default styles for each platform makes it very hard to write a reftests that works on all.
> 
> > Windows?
> 
> I'll grab the windows image results from the bots as needed.

Just be sure you mark 'em as failing/missing initially.

[Emil A Eklund]

Committed r119512: <http://trac.webkit.org/changeset/119512>