Bug 88318 – When the previous block has negative margin and float property, text is NOT displayed correctly following the floating box.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[kyounga]

Created attachment 145741 [details]
reduced test case

I've attached the reduced test case. 
FireFox, Opera : OK.
Safari, Chrome : fails

I think this is a duplicate of bug 15956.

[kyounga]

Created attachment 146817 [details]
first patch

[Levi Weintraub]

(In reply to comment #1)
> I think this is a duplicate of bug 15956.

The test case on Bug 15956 repros in FFX, but this one does not.

[kyounga]

Created attachment 150553 [details]
first patch.

[kyounga]

I've attached my first patch again.
This is same with the previous one. 
Of course, it was tested on my mac (os X), but the build-bot reported error on mac-ews. 
I have no idea the why, so I'm just re-tried.

Please review this, and add any comments

[WebKit Review Bot]

Comment on attachment 150553 [details]
first patch. 

Attachment 150553 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13126402

New failing tests:
fast/block/float/previous-sibling-float-002.html

[WebKit Review Bot]

Created attachment 150558 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[kyounga]

Honestly, I cannot understand this result. I mean, Is the test failed on only Chrome ? 
Both of browsers(Chrome, Safari) is based on same WebCore layout engine. isn't? 
If so, How the result is different? 

Or, If the engine is different, what should I do? 
Should I check the Chrome's layout engine or change the this issue's "platform" property like "mac only"?

Welcome any comments.please

[Pravin D]

(In reply to comment #8)
> Honestly, I cannot understand this result. I mean, Is the test failed on only Chrome ? 
> Both of browsers(Chrome, Safari) is based on same WebCore layout engine. isn't? 
> If so, How the result is different? 
> 
> Or, If the engine is different, what should I do? 
> Should I check the Chrome's layout engine or change the this issue's "platform" property like "mac only"?
> 
> Welcome any comments.please
> 
Only Chrome EWS runs the layout tests. If you run the same failing test case on the platform on which your working(with ur patch ) ur likely to get the same failure...

[Robert Hogan]

The rendering on trunk looks OK to me and is the same as FF. Please re-open and state the expected result if I'm wrong.

[kyounga]

resolved by https://bugs.webkit.org/show_bug.cgi?id=90646.

[Csaba Osztrogonác]

Comment on attachment 150553 [details]
first patch. 

Cleared review? from attachment 150553 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).