Bug 88292

Summary: [GTK] Build fix for Accelerated Compositing with OpenGL
Product: WebKit Reporter: Joone Hur <joone>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, mrobinson, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Patch
mrobinson: review+, mrobinson: commit-queue-
Updated Patch none

Joone Hur
Reported 2012-06-04 23:08:00 PDT
Currently, WebKitGtk+ doesn't need to include "GraphicsSurface.h" because USE(GRAPHICS_SURFACE) is not implemented.
Attachments
Proposed Patch (2.48 KB, patch)
2012-06-05 00:20 PDT, Joone Hur 		mrobinson: review+
mrobinson: commit-queue-
DetailsFormatted DiffDiff
Updated Patch (2.76 KB, patch)
2012-06-05 12:33 PDT, Joone Hur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joone Hur
Comment 1 2012-06-05 00:20:49 PDT
Created attachment 145709 [details] Proposed Patch
Martin Robinson
Comment 2 2012-06-05 08:10:04 PDT
Comment on attachment 145709 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145709&action=review Looks good, but please fix the include order when landing. > Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h:28 > + > +#if USE(GRAPHICS_SURFACE) > #include "GraphicsSurface.h" > +#endif > + You should now move this include below the rest of them, so it should be like: #include "FloatRect.h" #include "Image.h" #include "TextureMapper.h" #include "TextureMapperPlatformLayer.h" #include <wtf/RefPtr.h> #if USE(GRAPHICS_SURFACE) #include "GraphicsSurface.h" #endif > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:28 > #include "GraphicsContext.h" > + > +#if USE(GRAPHICS_SURFACE) > #include "GraphicsSurface.h" > +#endif > + The same thing is necessary here.
Joone Hur
Comment 3 2012-06-05 12:33:28 PDT
Created attachment 145854 [details] Updated Patch Thanks for the review!
WebKit Review Bot
Comment 4 2012-06-06 00:29:51 PDT
Comment on attachment 145854 [details] Updated Patch Clearing flags on attachment: 145854 Committed r119567: <http://trac.webkit.org/changeset/119567>
WebKit Review Bot
Comment 5 2012-06-06 00:29:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.