Bug 88273

Summary: nrwt should look in 'out' for binaries on chromium win to support ninja
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, scottmg, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch tony: review+

Dirk Pranke
Reported 2012-06-04 17:55:25 PDT
nrwt should look in 'out' for binaries on chromium win to support ninja
Attachments
Patch (3.75 KB, patch)
2012-06-04 18:00 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (20.52 KB, patch)
2012-06-06 17:18 PDT, Dirk Pranke 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-04 18:00:37 PDT
Created attachment 145670 [details] Patch
Tony Chang
Comment 2 2012-06-05 09:52:33 PDT
Comment on attachment 145670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145670&action=review > Tools/ChangeLog:3 > + nrwt should look in 'out' for binaries on chromium win to support ninja With this change, mac, linux, and win all look in 'out' (sometimes first, sometimes second). It would be nice if we pushed the out logic up into chromium.py.
Dirk Pranke
Comment 3 2012-06-05 13:06:43 PDT
(In reply to comment #2) > (From update of attachment 145670 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145670&action=review > > > Tools/ChangeLog:3 > > + nrwt should look in 'out' for binaries on chromium win to support ninja > > With this change, mac, linux, and win all look in 'out' (sometimes first, sometimes second). It would be nice if we pushed the out logic up into chromium.py. This is a fair point. Each port uses different logic as well as different locations, but that's probably not a good thing. I'll see if I can unify them.
Dirk Pranke
Comment 4 2012-06-06 17:18:12 PDT
Created attachment 146154 [details] Patch
Dirk Pranke
Comment 5 2012-06-06 17:32:04 PDT
Committed r119649: <http://trac.webkit.org/changeset/119649>
Note You need to log in before you can comment on or make changes to this bug.