Bug 88269

Summary:

test-webkitpy is hanging under cygwin

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, jberlin, ojan, rniwa, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

88020

Attachments:

Description	Flags
Patch	none
add changelog comments	rniwa: review+

Description Dirk Pranke 2012-06-04 17:05:36 PDT

test-webkitpy is hanging under cygwin

Comment 1 Dirk Pranke 2012-06-04 17:07:26 PDT

Created attachment 145659 [details]
Patch

Comment 2 Ryosuke Niwa 2012-06-04 17:32:24 PDT

Comment on attachment 145659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145659&action=review

> Tools/ChangeLog:7
> +

Please describe why you're making this change.

Comment 3 Dirk Pranke 2012-06-04 17:33:56 PDT

Created attachment 145661 [details]
add changelog comments

Comment 4 Ryosuke Niwa 2012-06-04 17:35:22 PDT

Comment on attachment 145661 [details]
add changelog comments

View in context: https://bugs.webkit.org/attachment.cgi?id=145661&action=review

> Tools/ChangeLog:9
> +        yet, so we need to skip any tests that use it.

Maybe put "yet," on the previous line so that it reads more naturally?

Comment 5 Dirk Pranke 2012-06-04 17:37:15 PDT

done.

Comment 6 Dirk Pranke 2012-06-04 17:37:39 PDT

Committed r119445: <http://trac.webkit.org/changeset/119445>