Bug 88269 - test-webkitpy is hanging under cygwin
Summary: test-webkitpy is hanging under cygwin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 88020
  Show dependency treegraph
 
Reported: 2012-06-04 17:05 PDT by Dirk Pranke
Modified: 2012-06-04 17:37 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.30 KB, patch)
2012-06-04 17:07 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
add changelog comments (2.43 KB, patch)
2012-06-04 17:33 PDT, Dirk Pranke
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-06-04 17:05:36 PDT
test-webkitpy is hanging under cygwin
Comment 1 Dirk Pranke 2012-06-04 17:07:26 PDT
Created attachment 145659 [details]
Patch
Comment 2 Ryosuke Niwa 2012-06-04 17:32:24 PDT
Comment on attachment 145659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145659&action=review

> Tools/ChangeLog:7
> +

Please describe why you're making this change.
Comment 3 Dirk Pranke 2012-06-04 17:33:56 PDT
Created attachment 145661 [details]
add changelog comments
Comment 4 Ryosuke Niwa 2012-06-04 17:35:22 PDT
Comment on attachment 145661 [details]
add changelog comments

View in context: https://bugs.webkit.org/attachment.cgi?id=145661&action=review

> Tools/ChangeLog:9
> +        yet, so we need to skip any tests that use it.

Maybe put "yet," on the previous line so that it reads more naturally?
Comment 5 Dirk Pranke 2012-06-04 17:37:15 PDT
done.
Comment 6 Dirk Pranke 2012-06-04 17:37:39 PDT
Committed r119445: <http://trac.webkit.org/changeset/119445>