Bug 88246

Summary: [chromium] Remove redundant setNeedsCommit when prepareToDraw fails
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, jamesr, nduca, piman, webkit.review.bot, wjmaclean
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cq-03 none

Dana Jansens
Reported 2012-06-04 12:33:38 PDT
[chromium] Remove redundant setNeedsCommit when prepareToDraw fails
Attachments
Patch (3.48 KB, patch)
2012-06-04 12:38 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cq-03 (817.24 KB, application/zip)
2012-06-04 17:44 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-06-04 12:38:52 PDT
Created attachment 145616 [details] Patch
WebKit Review Bot
Comment 2 2012-06-04 17:44:10 PDT
Comment on attachment 145616 [details] Patch Rejecting attachment 145616 [details] from commit-queue. New failing tests: perf/object-keys.html Full output: http://queues.webkit.org/results/12903324
WebKit Review Bot
Comment 3 2012-06-04 17:44:14 PDT
Created attachment 145664 [details] Archive of layout-test-results from ec2-cq-03 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
James Robinson
Comment 4 2012-06-04 17:47:51 PDT
Comment on attachment 145616 [details] Patch That would be a flake
WebKit Review Bot
Comment 5 2012-06-04 18:07:47 PDT
Comment on attachment 145616 [details] Patch Clearing flags on attachment: 145616 Committed r119447: <http://trac.webkit.org/changeset/119447>
WebKit Review Bot
Comment 6 2012-06-04 18:07:53 PDT
All reviewed patches have been landed. Closing bug.
Dana Jansens
Comment 7 2012-06-05 08:20:28 PDT
Thanks for re-cq'ing for me
Note You need to log in before you can comment on or make changes to this bug.