Bug 88243 – Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Hugo Parente Lima]

Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag, as it better fits into ENABLE flag definition.

[Hugo Parente Lima]

Created attachment 145613 [details]
Patch

[Adam Barth]

Comment on attachment 145613 [details]
Patch

Is LEGACY_VIEWPORT_ADAPTION only mentioned in the cmake build system?  I would have expected you to change some of the other build systems as well.

[Hugo Parente Lima]

Yes, I only added it on qmake and cmake (false by default), but as the default value should be false on other ports until the respective maintainers take the decision to turn it on this shall be no problem.

[Hugo Parente Lima]

Continuing..., as the feature is off by default, better to delegate the implementation of this flag on other build system to people that really understand those build systems, when and if they decide to use this feature.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 145613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145613&action=review

> Source/cmake/WebKitFeatures.cmake:59
> +    WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF)

BTW, for CMake you also need to change Source/cmakeconfig.h.cmake.

[Hugo Parente Lima]

(In reply to comment #5)
> (From update of attachment 145613 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145613&action=review
> 
> > Source/cmake/WebKitFeatures.cmake:59
> > +    WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF)
> 
> BTW, for CMake you also need to change Source/cmakeconfig.h.cmake.

I saw the file, but I was not sure if adding the flag there would enable the feature, so for the sake of not mess with other ports I didn't touch the file.

rakuko, could you complete the addition of this feature flag for cmake?

[WebKit Review Bot]

Comment on attachment 145613 [details]
Patch

Clearing flags on attachment: 145613

Committed r119452: <http://trac.webkit.org/changeset/119452>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.