Bug 88226

Summary: [Qt][WK2] Rename QtViewportInteractionEngine to QtViewportHandler
Product: WebKit Reporter: alan <zalan>
Component: WebKit2Assignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, hausmann, kenneth, menard, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2012-06-04 04:57:13 PDT
as discussed with Kenneth and Simon. New name reflects functionality better.
Attachments
Patch (113.44 KB, patch)
2012-06-04 06:15 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (112.88 KB, patch)
2012-06-04 07:18 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2012-06-04 06:15:49 PDT
Created attachment 145572 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-06-04 06:26:24 PDT
Comment on attachment 145572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145572&action=review > Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp:689 > +QRect QtViewportInteractionEngine::visibleContentsRect() const huh? half rename?
alan
Comment 3 2012-06-04 06:29:29 PDT
(In reply to comment #2) > (From update of attachment 145572 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145572&action=review > > > Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp:689 > > +QRect QtViewportInteractionEngine::visibleContentsRect() const > > huh? half rename? uh, probably wrong diff. :(
alan
Comment 4 2012-06-04 06:33:35 PDT
Comment on attachment 145572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145572&action=review >>> Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp:689 >>> +QRect QtViewportHandler::visibleContentsRect() const >> >> huh? half rename? > > uh, probably wrong diff. :( actually it shows - for Interaction and + for Handler in my view. and my local copy is like that too.
Kenneth Rohde Christiansen
Comment 5 2012-06-04 06:34:22 PDT
anyway rs=me but can you land manually?
alan
Comment 6 2012-06-04 07:18:50 PDT
Created attachment 145580 [details] Patch
Kenneth Rohde Christiansen
Comment 7 2012-06-04 07:21:32 PDT
Comment on attachment 145580 [details] Patch lets hope this is correct and just due to the renaming... or lets do the file renaming separately
WebKit Review Bot
Comment 8 2012-06-04 08:31:04 PDT
Comment on attachment 145580 [details] Patch Clearing flags on attachment: 145580 Committed r119400: <http://trac.webkit.org/changeset/119400>
WebKit Review Bot
Comment 9 2012-06-04 08:31:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.