Bug 88209

Summary: Use SelectorQuery in Element::webkitMatchesSelector()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: CSSAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, darin, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87625    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-06-03 20:55:17 PDT
By using SelectorQuery in Element::webkitMatchesSelector(), we can not only simplify the code but also improve the performance thanks to the cache mechanism of SelectorQuery which was implemented in bug 87942.
Attachments
Patch (4.02 KB, patch)
2012-06-03 20:58 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-06-03 20:58:25 PDT
Created attachment 145511 [details] Patch
Kentaro Hara
Comment 2 2012-06-03 20:59:07 PDT
I've found that SelectorDataList::matches() had been used by nobody before this patch:)
Antti Koivisto
Comment 3 2012-06-04 01:39:37 PDT
Comment on attachment 145511 [details] Patch r=me
WebKit Review Bot
Comment 4 2012-06-04 01:52:24 PDT
Comment on attachment 145511 [details] Patch Clearing flags on attachment: 145511 Committed r119375: <http://trac.webkit.org/changeset/119375>
WebKit Review Bot
Comment 5 2012-06-04 01:52:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.