Bug 88207

Summary:

[EFL][WK2] Make WebKit2/Efl headers and resources installable.

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebKit EFL

Assignee:

Ryuan Choi <ryuan.choi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cshu, gyuyoung.kim, lucas.de.marchi, rakuco, s.choi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

84124, 88767

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Ryuan Choi

Reported 2012-06-03 20:09:13 PDT

WebKit2/Efl should install public header files and .pc for separated webkit2-efl based project.

Attachments
Patch (2.90 KB, patch) 2012-06-10 16:44 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Patch (2.94 KB, patch) 2012-06-11 23:23 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Patch (5.28 KB, patch) 2012-06-21 07:45 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ryuan Choi

Comment 1 2012-06-10 16:44:52 PDT

Created attachment 146756 [details] Patch

Gyuyoung Kim

Comment 2 2012-06-10 22:00:21 PDT

Comment on attachment 146756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146756&action=review > Source/WebKit2/CMakeLists.txt:547 > +INSTALL(TARGETS ${WebProcess_NAME} DESTINATION bin) Why do you install WebProcess library to *bin* directory? *bin* is directory for executable. If WebProcess is executable, it looks it is more clear to add _EXECUTABLE_ to WebProcess_NAME.

Ryuan Choi

Comment 3 2012-06-11 01:15:24 PDT

(In reply to comment #2) > (From update of attachment 146756 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146756&action=review > > > Source/WebKit2/CMakeLists.txt:547 > > +INSTALL(TARGETS ${WebProcess_NAME} DESTINATION bin) > > Why do you install WebProcess library to *bin* directory? *bin* is directory for executable. If WebProcess is executable, it looks it is more clear to add _EXECUTABLE_ to WebProcess_NAME. Yes, WebProcess is executable. I created bug 88767 to catch up what you mentioned. Thank you.

Ryuan Choi

Comment 4 2012-06-11 23:23:30 PDT

Created attachment 147015 [details] Patch

Gyuyoung Kim

Comment 5 2012-06-13 03:12:30 PDT

Comment on attachment 147015 [details] Patch Looks good to me now.

Chang Shu

Comment 6 2012-06-21 06:50:02 PDT

Comment on attachment 147015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147015&action=review > Source/WebKit2/CMakeLists.txt:546 > +INSTALL(TARGETS ${WebProcess_EXECUTABLE_NAME} DESTINATION bin) I think it's better to use a defined name such as ${EXEC_INSTALL_DIR} than a hardcoded "bin". Can you figure out where ${LIB_INSTALL_DIR} is defined? Please take a loot at bug 71507.

Ryuan Choi

Comment 7 2012-06-21 07:45:34 PDT

Created attachment 148800 [details] Patch

Ryuan Choi

Comment 8 2012-06-21 07:46:24 PDT

(In reply to comment #6) > (From update of attachment 147015 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147015&action=review > > > Source/WebKit2/CMakeLists.txt:546 > > +INSTALL(TARGETS ${WebProcess_EXECUTABLE_NAME} DESTINATION bin) > > I think it's better to use a defined name such as ${EXEC_INSTALL_DIR} than a hardcoded "bin". Can you figure out where ${LIB_INSTALL_DIR} is defined? > Please take a loot at bug 71507. Thank you. I updated like you mentioned.

Chang Shu

Comment 9 2012-06-21 07:59:22 PDT

Comment on attachment 148800 [details] Patch r=me.

WebKit Review Bot

Comment 10 2012-06-21 08:46:57 PDT

Comment on attachment 148800 [details] Patch Clearing flags on attachment: 148800 Committed r120927: <http://trac.webkit.org/changeset/120927>

WebKit Review Bot

Comment 11 2012-06-21 08:47:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.