Bug 88205

Summary: get_argument_by_val should be profiled everywhere
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2012-06-03 19:27:06 PDT
The JSVALUE64 JIT does it on fast and slow paths. The 32_64 JIT does it on fast paths only. The LLInt does it on fast paths only. All implementations of this opcode ought to be profiled.
Attachments
the patch (1.84 KB, patch)
2012-06-03 19:40 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-06-03 19:40:20 PDT
Created attachment 145507 [details] the patch
Geoffrey Garen
Comment 2 2012-06-03 22:27:41 PDT
Comment on attachment 145507 [details] the patch r=me
Filip Pizlo
Comment 3 2012-06-04 16:33:19 PDT
Landed in http://trac.webkit.org/changeset/119438
Note You need to log in before you can comment on or make changes to this bug.