Bug 88175

Summary: DOM string cache should hash pointers, not characters
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, philn, rniwa, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Geoffrey Garen
Reported 2012-06-02 14:05:51 PDT
DOM string cache should hash pointers, not characters
Attachments
Patch (4.78 KB, patch)
2012-06-02 14:28 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (7.77 KB, patch)
2012-06-02 15:28 PDT, Geoffrey Garen 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2012-06-02 14:28:51 PDT
Created attachment 145459 [details] Patch
Geoffrey Garen
Comment 2 2012-06-02 15:28:31 PDT
Created attachment 145461 [details] Patch
Geoffrey Garen
Comment 3 2012-06-02 15:49:32 PDT
Committed r119341: <http://trac.webkit.org/changeset/119341>
Ryosuke Niwa
Comment 4 2012-06-02 20:07:41 PDT
It appears that this patch broke Windows build: http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/49801/steps/compile-webkit/logs/stdio 7> Creating library C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\DumpRenderTree.lib and object C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\DumpRenderTree.exp 7>WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::jsStringSlowCase(class JSC::ExecState *,class WTF::HashMap<class WTF::StringImpl *,class JSC::Weak<class JSC::JSString>,struct WTF::PtrHash<class WTF::StringImpl *>,struct WTF::HashTraits<class WTF::StringImpl *>,struct WTF::HashTraits<class JSC::Weak<class JSC::JSString> > > &,class WTF::StringImpl *)" (?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@U?$PtrHash@PAVStringImpl@WTF@@@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z) referenced in function "class JSC::JSValue __cdecl WebCore::jsString(class JSC::ExecState *,class WTF::String const &)" (?jsString@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@ABVString@WTF@@@Z) 7>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\bin\DumpRenderTree.dll : fatal error LNK1120: 1 unresolved externals 7>Build log was saved at "file://C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\obj\DumpRenderTree\BuildLog.htm" 7>DumpRenderTree - 2 error(s), 0 warning(s)
Geoffrey Garen
Comment 5 2012-06-02 20:46:30 PDT
WIndows build fix: <http://trac.webkit.org/changeset/119351>.
Note You need to log in before you can comment on or make changes to this bug.