Summary: | DFG constant folding should be OK with GetLocal of captured variables having a constant | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ggaren, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2012-06-01 14:27:30 PDT
Created attachment 145376 [details]
the patch
r=me
> LayoutTests/fast/js/dfg-cse-cfa-discrepancy-expected.txt:1
> +Tests stability when the CFA finds a constant in block-local data flow over captured variables but the CSE doesn't because if differences in heap modeling.
Typo: "if" should be "of".
Landed in http://trac.webkit.org/changeset/119281, but before I saw Gavin's comment. Fix for that on the way. Typo fix in http://trac.webkit.org/changeset/119282 (In reply to comment #4) > Typo fix in http://trac.webkit.org/changeset/119282 And did the same in the expected result: http://trac.webkit.org/changeset/119288 (In reply to comment #5) > (In reply to comment #4) > > Typo fix in http://trac.webkit.org/changeset/119282 > > And did the same in the expected result: http://trac.webkit.org/changeset/119288 Ooops! Thank you for fixing this! |