Bug 88119

Summary: REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 oliver: review+

Description Brady Eidson 2012-06-01 12:07:09 PDT 
REGRESSION (r99448) Zero-sized plugins never get an NPP_SetWindow call

The regression from 99448 was specifically about Netscape plug-ins on Mac, but it's a theoretical problem on all WK2 ports.

In radar as <rdar://problem/11335622>
Comment 1 Brady Eidson 2012-06-01 12:15:59 PDT 
Created attachment 145354 [details]
Patch v1
Comment 2 Anders Carlsson 2012-06-01 12:22:54 PDT 
Comment on attachment 145354 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=145354&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:715
> +    m_hasCalledSetWindow = true;

I think you should set this to true in callSetWindow, since it can be called from platformPaint as well.
Comment 3 Brady Eidson 2012-06-01 12:24:57 PDT 
http://trac.webkit.org/changeset/119260
Comment 4 Brady Eidson 2012-06-01 12:28:59 PDT 
(In reply to comment #2)
> (From update of attachment 145354 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145354&action=review
> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:715
> > +    m_hasCalledSetWindow = true;
> 
> I think you should set this to true in callSetWindow, since it can be called from platformPaint as well.

I was trying to keep it local to where it was used, having done an (apparently faulty) search for other callers and coming up empty.

Makes sense, and will do in a followup.
Comment 5 Brady Eidson 2012-06-01 12:32:36 PDT 
Followed up in http://trac.webkit.org/changeset/119261