Bug 88110

Summary: Prepare table collapsed border computation to support mixed directionality on row group
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: TablesAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyatt, mitz, ojan, robert, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 87900    
Attachments:
Description Flags
Proposed preparation. Comments on naming more than welcome.
none
Patch for landing none

Julien Chaffraix
Reported 2012-06-01 11:00:57 PDT
The code doesn't handle mixed directionality inside a table and will fail pretty badly if it is involved. CSS 2.1 and CSS 3 writing-modes however allow the use of mixed directionality. The difficulty with mixed directionality is that the start / end borders don't map strictly anymore: the table start border will be the section's end border if the table and section have mixed directionality. To account for that, we need new methods to properly get the adjoining borders regardless of the directions.
Attachments
Proposed preparation. Comments on naming more than welcome. (15.04 KB, patch)
2012-06-01 11:19 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.00 KB, patch)
2012-06-01 12:30 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-06-01 11:19:37 PDT
Created attachment 145340 [details] Proposed preparation. Comments on naming more than welcome.
Julien Chaffraix
Comment 2 2012-06-01 11:28:17 PDT
CC'ing some people who could comment on the naming used.
Ojan Vafai
Comment 3 2012-06-01 12:06:51 PDT
Comment on attachment 145340 [details] Proposed preparation. Comments on naming more than welcome. View in context: https://bugs.webkit.org/attachment.cgi?id=145340&action=review > Source/WebCore/ChangeLog:14 > + This change add the concept of adjoining borders in the table direction so that we can safely s/add/adds > Source/WebCore/rendering/RenderTableSection.h:127 > + // These methods handle mixed directions between table and sections. Meh. This is a what comment. That will be clear once you do your followup patch. No need to add a comment saying it.
Julien Chaffraix
Comment 4 2012-06-01 12:30:13 PDT
Created attachment 145356 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-06-01 13:15:19 PDT
Comment on attachment 145356 [details] Patch for landing Clearing flags on attachment: 145356 Committed r119272: <http://trac.webkit.org/changeset/119272>
WebKit Review Bot
Comment 6 2012-06-01 13:15:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.