Bug 88106

Summary: Crash in WebCore::FontFallbackList::determinePitch
Product: WebKit Reporter: Eli Fidler <efidler>
Component: TextAssignee: Eli Fidler <efidler>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, rwlbuis, staikos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Eli Fidler
Reported 2012-06-01 10:12:50 PDT
If the site doesn't ask for a reasonable font and the system doesn't provide a good fallback, FontFallBackList::primaryFontData can be 0.
Attachments
Patch (1.58 KB, patch)
2012-06-01 10:15 PDT, Eli Fidler 		no flags
DetailsFormatted DiffDiff
Patch (1.79 KB, patch)
2012-06-01 14:16 PDT, Eli Fidler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eli Fidler
Comment 1 2012-06-01 10:15:57 PDT
Created attachment 145335 [details] Patch
mitz
Comment 2 2012-06-01 12:03:04 PDT
Comment on attachment 145335 [details] Patch There are many places in the code that require primaryFontData to be non-0. This bug should be fixed in the FontCache implementation so that it always provides some font as a last resort.
Eli Fidler
Comment 3 2012-06-01 14:16:36 PDT
Created attachment 145375 [details] Patch
WebKit Review Bot
Comment 4 2012-06-02 14:52:50 PDT
Comment on attachment 145375 [details] Patch Clearing flags on attachment: 145375 Committed r119340: <http://trac.webkit.org/changeset/119340>
WebKit Review Bot
Comment 5 2012-06-02 14:53:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.