| Summary: | rename -webkit-flex-order to -webkit-order | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, eric, macpherson, menard, ojan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 62048 | ||||||
| Attachments: |
|
||||||
|
Description
Tony Chang
2012-06-01 09:36:45 PDT
Created attachment 145329 [details]
Patch
Comment on attachment 145329 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145329&action=review > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:149 > + int m_order; It's a bummer that we use so many bits for this. :( What do we do for z-index? Also, per-spec, isn't this a float now? Obviously, none of these changes would happen in this patch. Just bringing it up since I'm noticing the code. (In reply to comment #2) > (From update of attachment 145329 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145329&action=review > > > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:149 > > + int m_order; > > It's a bummer that we use so many bits for this. :( What do we do for z-index? z-index is an int. It hangs off of StyleBoxData which has things like min/max width/height and vertical align. > Also, per-spec, isn't this a float now? Obviously, none of these changes would happen in this patch. Just bringing it up since I'm noticing the code. Huh, I didn't notice that change. I've filed 88111 for this. Comment on attachment 145329 [details] Patch Clearing flags on attachment: 145329 Committed r119255: <http://trac.webkit.org/changeset/119255> All reviewed patches have been landed. Closing bug. |