Bug 88081

Summary: Web Inspector: add unknown size to the memory pie-chart legend
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 87262    
Attachments:
Description Flags
Patch
none
Patch none

Yury Semikhatsky
Reported 2012-06-01 05:45:01 PDT
We only show total size and all known parts, unknown part should also be presented.
Attachments
Patch (5.89 KB, patch)
2012-06-01 05:46 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (6.01 KB, patch)
2012-06-01 06:12 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-06-01 05:46:18 PDT
Created attachment 145278 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-06-01 06:02:42 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=145278&action=review > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:105 > + memoryBlock.children.push({ > + name: "Unknown", > + size: memoryBlock.size - knownSize I think it is not necessary to add 'unknown' memory block if unknown size is equal to 0.
Yury Semikhatsky
Comment 3 2012-06-01 06:12:13 PDT
Created attachment 145286 [details] Patch
Yury Semikhatsky
Comment 4 2012-06-01 06:12:33 PDT
(In reply to comment #2) > View in context: https://bugs.webkit.org/attachment.cgi?id=145278&action=review > > > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:105 > > + memoryBlock.children.push({ > > + name: "Unknown", > > + size: memoryBlock.size - knownSize > > I think it is not necessary to add 'unknown' memory block if unknown size is equal to 0. Done.
Ilya Tikhonovsky
Comment 5 2012-06-04 05:02:36 PDT
Comment on attachment 145286 [details] Patch Clearing flags on attachment: 145286 Committed r119386: <http://trac.webkit.org/changeset/119386>
Ilya Tikhonovsky
Comment 6 2012-06-04 05:02:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.