Bug 88081

Summary: Web Inspector: add unknown size to the memory pie-chart legend
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 87262    
Attachments:
Description Flags
Patch
none
Patch none

Description Yury Semikhatsky 2012-06-01 05:45:01 PDT 
We only show total size and all known parts, unknown part should also be presented.
Comment 1 Yury Semikhatsky 2012-06-01 05:46:18 PDT 
Created attachment 145278 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-06-01 06:02:42 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=145278&action=review

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:105
> +                memoryBlock.children.push({
> +                    name: "Unknown",
> +                    size: memoryBlock.size - knownSize

I think it is not necessary to add 'unknown' memory block if unknown size is equal to 0.
Comment 3 Yury Semikhatsky 2012-06-01 06:12:13 PDT 
Created attachment 145286 [details]
Patch
Comment 4 Yury Semikhatsky 2012-06-01 06:12:33 PDT 
(In reply to comment #2)
> View in context: https://bugs.webkit.org/attachment.cgi?id=145278&action=review
> 
> > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:105
> > +                memoryBlock.children.push({
> > +                    name: "Unknown",
> > +                    size: memoryBlock.size - knownSize
> 
> I think it is not necessary to add 'unknown' memory block if unknown size is equal to 0.

Done.
Comment 5 Ilya Tikhonovsky 2012-06-04 05:02:36 PDT 
Comment on attachment 145286 [details]
Patch

Clearing flags on attachment: 145286

Committed r119386: <http://trac.webkit.org/changeset/119386>
Comment 6 Ilya Tikhonovsky 2012-06-04 05:02:44 PDT 
All reviewed patches have been landed.  Closing bug.