Summary: | [BlackBerry] Add end editing handling into AutofillManager | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Dong <jonathan.dong.webkit> | ||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | charles.wei, leo.yang, rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jonathan Dong
2012-06-01 03:28:32 PDT
Created attachment 145261 [details]
Patch
Comment on attachment 145261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145261&action=review Looks good. > Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:44 > + void didEndEditing(HTMLInputElement*); Since other methods use TextField in the name, and we call it from EditorClientBlackBerry::textFieldDidEndEditing, you should probably add TextField in this function too. Created attachment 145303 [details]
Patch
Comment on attachment 145303 [details] Patch Clearing flags on attachment: 145303 Committed r119239: <http://trac.webkit.org/changeset/119239> All reviewed patches have been landed. Closing bug. |