Summary: | [BlackBerry] IndexedDB file should be sand-boxed to the application data directory. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Charles Wei <charles.wei> | ||||||
Component: | WebKit BlackBerry | Assignee: | Charles Wei <charles.wei> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jrogers, rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Charles Wei
2012-06-01 02:30:45 PDT
Created attachment 145247 [details]
Patch
Comment on attachment 145247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145247&action=review > Source/WebCore/Modules/indexeddb/IDBFactory.cpp:102 > + m_backend->open(name, request.get(), context->securityOrigin(), frame, String(BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str())); Is it possible to put get dataDir in a port specific section? So if dataDir is empty we call BlackBerry::Platform::Client::get()->getApplicationDataDirectory()? Or is there nothing port specific? Comment on attachment 145247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145247&action=review >> Source/WebCore/Modules/indexeddb/IDBFactory.cpp:102 >> + m_backend->open(name, request.get(), context->securityOrigin(), frame, String(BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str())); > > Is it possible to put get dataDir in a port specific section? So if dataDir is empty we call BlackBerry::Platform::Client::get()->getApplicationDataDirectory()? Or is there nothing port specific? Yes, we should make that at a port specific section. I'll try with another patch. Thanks. Created attachment 145909 [details]
Patch
Comment on attachment 145909 [details] Patch Clearing flags on attachment: 145909 Committed r119566: <http://trac.webkit.org/changeset/119566> All reviewed patches have been landed. Closing bug. |