Bug 88038

Summary: [Chromium] Call clipboard methods directly
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-05-31 19:49:59 PDT
[Chromium] Call clipboard methods directly
Attachments
Patch (24.94 KB, patch)
2012-05-31 19:50 PDT, Mark Pilgrim (Google)
no flags
Patch (26.21 KB, patch)
2012-06-01 06:34 PDT, Mark Pilgrim (Google)
no flags
Mark Pilgrim (Google)
Comment 1 2012-05-31 19:50:35 PDT
Mark Pilgrim (Google)
Comment 2 2012-05-31 19:51:07 PDT
*** Bug 88037 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 3 2012-05-31 19:52:25 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 4 2012-05-31 22:12:00 PDT
Comment on attachment 145200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145200&action=review > Source/Platform/chromium/public/WebClipboard.h:65 > - virtual uint64 sequenceNumber(Buffer) { return 0; } > + virtual uint64_t sequenceNumber(Buffer) { return 0; } I'm surprised this change is needed, but it seems harmless.
WebKit Review Bot
Comment 5 2012-06-01 00:06:46 PDT
Comment on attachment 145200 [details] Patch Attachment 145200 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12873182
Mark Pilgrim (Google)
Comment 6 2012-06-01 06:34:10 PDT
Mark Pilgrim (Google)
Comment 7 2012-06-01 06:34:42 PDT
Comment on attachment 145290 [details] Patch Updated GYPI file.
WebKit Review Bot
Comment 8 2012-06-01 11:55:47 PDT
Comment on attachment 145290 [details] Patch Clearing flags on attachment: 145290 Committed r119258: <http://trac.webkit.org/changeset/119258>
WebKit Review Bot
Comment 9 2012-06-01 11:55:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.