| Summary: | [Chromium] Call clipboard methods directly | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||
| Component: | WebKit Misc. | Assignee: | Mark Pilgrim (Google) <pilgrim> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 82948 | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Pilgrim (Google)
2012-05-31 19:49:59 PDT
Created attachment 145200 [details]
Patch
*** Bug 88037 has been marked as a duplicate of this bug. *** Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 145200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145200&action=review > Source/Platform/chromium/public/WebClipboard.h:65 > - virtual uint64 sequenceNumber(Buffer) { return 0; } > + virtual uint64_t sequenceNumber(Buffer) { return 0; } I'm surprised this change is needed, but it seems harmless. Comment on attachment 145200 [details] Patch Attachment 145200 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12873182 Created attachment 145290 [details]
Patch
Comment on attachment 145290 [details]
Patch
Updated GYPI file.
Comment on attachment 145290 [details] Patch Clearing flags on attachment: 145290 Committed r119258: <http://trac.webkit.org/changeset/119258> All reviewed patches have been landed. Closing bug. |