Bug 87977

Summary: [Qt] Clean up our viewport handling mess
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit QtAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, hausmann, menard, webkit.review.bot, zalan, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch hausmann: review+

Kenneth Rohde Christiansen
Reported 2012-05-31 07:49:35 PDT
Consolidated functionality from QQuickWebViewPrivate* into ViewportInteractionEngine that belongs there, in preparation for renaming ViewportInteractionEngine in the future.
Attachments
Patch (20.09 KB, patch)
2012-05-31 07:50 PDT, Kenneth Rohde Christiansen 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-05-31 07:50:28 PDT
Created attachment 145092 [details] Patch
Andras Becsi
Comment 2 2012-05-31 08:38:48 PDT
Comment on attachment 145092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145092&action=review The patch looks generally good to me. > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:858 > + // FIXME: Examine why there is not an interactionEngine here in the beginning. The interactionEngine is created when the WebView component is completed in QQuickWebViewFlickablePrivate::onComponentComplete(). This mainly has historical reasons but it also reduces updates on startup.
Kenneth Rohde Christiansen
Comment 3 2012-06-01 04:14:29 PDT
Landed in 119210
Note You need to log in before you can comment on or make changes to this bug.