Bug 87975

Summary: Web Inspector: [JSC] Add WebGL instrumentation support
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, caseq, eustas.bug, haraken, japhet, jochen, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 87960    
Bug Blocks: 87959    
Attachments:
Description Flags
Patch
none
Patch none

Andrey Adaikin
Reported 2012-05-31 07:44:26 PDT
FIXME at Source/WebCore/bindings/js/JSInjectedScriptManager.cpp
Attachments
Patch (3.13 KB, patch)
2012-06-06 02:07 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Patch (9.02 KB, patch)
2012-06-06 04:34 PDT, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2012-06-06 02:07:33 PDT
Created attachment 145965 [details] Patch
Vsevolod Vlasov
Comment 2 2012-06-06 04:02:50 PDT
Comment on attachment 145965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145965&action=review > Source/WebCore/bindings/js/JSInjectedScriptManager.cpp:91 > +ScriptObject InjectedScriptManager::injectWebGLScript(const String& source, ScriptObject glContext) You should pass ScriptObject by reference (both here and in v8).
Andrey Adaikin
Comment 3 2012-06-06 04:34:21 PDT
Created attachment 145990 [details] Patch
Andrey Kosyakov
Comment 4 2012-06-06 07:12:51 PDT
Comment on attachment 145990 [details] Patch Clearing flags on attachment: 145990 Committed r119589: <http://trac.webkit.org/changeset/119589>
Andrey Kosyakov
Comment 5 2012-06-06 07:13:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.