Bug 87955

Summary: [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
Product: WebKit Reporter: Tor Arne Vestbø <vestbo>
Component: New BugsAssignee: Tor Arne Vestbø <vestbo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, eric.carlson, feature-media-reviews, gustavo, menard, mrobinson, pnormand, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch hausmann: review+

Tor Arne Vestbø
Reported 2012-05-31 04:51:54 PDT
[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
Attachments
Patch (40.47 KB, patch)
2012-05-31 04:53 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Patch (41.54 KB, patch)
2012-05-31 05:55 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Patch (41.58 KB, patch)
2012-05-31 06:17 PDT, Tor Arne Vestbø 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2012-05-31 04:53:39 PDT
Created attachment 145051 [details] Patch
WebKit Review Bot
Comment 2 2012-05-31 04:56:21 PDT
Attachment 145051 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/qt..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2012-05-31 05:06:27 PDT
Comment on attachment 145051 [details] Patch Attachment 145051 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12866198
Early Warning System Bot
Comment 4 2012-05-31 05:09:21 PDT
Comment on attachment 145051 [details] Patch Attachment 145051 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12859322
Tor Arne Vestbø
Comment 5 2012-05-31 05:55:43 PDT
Created attachment 145065 [details] Patch Fixed missing config.h includes and use of HAVE macro in moc'ed headers
Tor Arne Vestbø
Comment 6 2012-05-31 06:17:46 PDT
Created attachment 145073 [details] Patch Fix one last missing moc'ed header
Tor Arne Vestbø
Comment 7 2012-05-31 07:01:15 PDT
Committed r119098: <http://trac.webkit.org/changeset/119098>
Note You need to log in before you can comment on or make changes to this bug.