Bug 87944 – WebCore fails to compile with SVG disabled.

• Component: CSS
• Status: RESOLVED FIXED

[Mike West]

The Chromium port fails to compile on linux w/ ninja/clang:

../../Source/WebCore/css/StyleResolver.cpp:3183:13: error: enumeration value 'CSSPropertyWebkitBoxDecorationBreak' not handled in switch [-Werror,-Wswitch]
    switch (id) {

../../Source/WebCore/css/CSSParser.cpp:1521:13: error: enumeration value 'CSSPropertyWebkitBoxDecorationBreak' not handled in switch [-Werror,-Wswitch]
    switch (propId) {

Looks like this started after https://bugs.webkit.org/show_bug.cgi?id=87678 landed r118853.

[Mike West]

Created attachment 145023 [details]
Patch

Comment on attachment 145023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145023&action=review

> Source/WebCore/ChangeLog:3
> +        Chromium port fails to compile on linux w/ ninja/clang

The patch looks good, but the changelog is incorrect. It's not Chromium ninja/clang that is the problem, but you try to compile with SVG disabled. If it's enabled, the switch statement has a default: branch, and so the compilers don't catch the missing enum value

[Mike West]

Created attachment 145025 [details]
Patch

[Mike West]

Thanks Jochen, that makes much more sense. I've updated the ChangeLog, and I'll head to IRC to find a reviewer.

Comment on attachment 145025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145025&action=review

> Source/WebCore/ChangeLog:3
> +        [Chromium] Fixing compilation with SVG disabled.

plz drop the [chromium], this affects all ports

[Mike West]

Created attachment 145028 [details]
Patch

[Mike West]

Ah. Right. Done.

[WebKit Review Bot]

Comment on attachment 145028 [details]
Patch

Clearing flags on attachment: 145028

Committed r119094: <http://trac.webkit.org/changeset/119094>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.