Bug 87941

Summary: [Platform] Implementation of Decimal(int32_t) isn't portable.
Product: WebKit Reporter: yosin
Component: PlatformAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 80009    
Attachments:
Description Flags
Patch 1 none

yosin
Reported 2012-05-31 01:35:32 PDT
The value of expression (i32 < 0 ? -i32 : i32) is undefined when i32 = std::numeric_limits<int32_t>::min(), e.g. 0x80000000.
Attachments
Patch 1 (1.56 KB, patch)
2012-05-31 02:04 PDT, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-05-31 02:04:42 PDT
Created attachment 145021 [details] Patch 1
yosin
Comment 2 2012-05-31 02:05:41 PDT
Comment on attachment 145021 [details] Patch 1 Could you review this patch? Thanks in advance. -yosi
Kent Tamura
Comment 3 2012-05-31 02:06:20 PDT
Comment on attachment 145021 [details] Patch 1 ok
WebKit Review Bot
Comment 4 2012-05-31 04:54:36 PDT
Comment on attachment 145021 [details] Patch 1 Clearing flags on attachment: 145021 Committed r119088: <http://trac.webkit.org/changeset/119088>
WebKit Review Bot
Comment 5 2012-05-31 04:54:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.