Bug 87939 – Syntax error in fast/filesystem/resources/file-writer-gc-blob.js

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Leo Yang]

var blob = tenXBlob(new Blob["lorem ipsum"]); <-- parentheses are missed around [].

[Leo Yang]

Created attachment 145016 [details]
Patch

[Alexey Proskuryakov]

What effect does this have on test results?

[Leo Yang]

(In reply to comment #2)
> What effect does this have on test results?

JSC generates something like: Type Error: "undefined" is not a constructor. Apparently Blob["lorem ipsum"] is undefined.

You might ask why this case passes. I would say all portings except for chromium that uses v8 don't support filesystem API so they don't run this case. The BlackBerry porting is implementing filesystem API with JSC. This case will fail using JSC.

[Alexey Proskuryakov]

Makes sense. What about chromium - why doesn't the test fail there? It looks like a v8 bindings bug if Blob["lorem ipsum"] === Blob.

[Leo Yang]

(In reply to comment #4)
> Makes sense. What about chromium - why doesn't the test fail there? It looks like a v8 bindings bug if Blob["lorem ipsum"] === Blob.

I have no idea why there is no error for v8. The fix is harmless for v8 since the cr-linux ews bot is green. IIRC, cr-linux ews bot will run layout tests.

[Kentaro Hara]

(In reply to comment #5)
> (In reply to comment #4)
> I have no idea why there is no error for v8. The fix is harmless for v8 since the cr-linux ews bot is green. IIRC, cr-linux ews bot will run layout tests.

That's because file-writer-gc-blob.html is skipped in LayoutTests/platform/chromium/TestExpectations due to bug 85174.

[Alexey Proskuryakov]

Comment on attachment 145016 [details]
Patch

Cool.

[WebKit Review Bot]

Comment on attachment 145016 [details]
Patch

Clearing flags on attachment: 145016

Committed r119454: <http://trac.webkit.org/changeset/119454>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kinuko Yasuda]

Ah I just noticed this fix.  Thanks for fixing!