Bug 87936

Summary:

[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

WebKit Qt

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, dinu.jacob, kenneth, menard, webkit.review.bot, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2012-05-31 00:50:59 PDT

SSIA

Comment 1 zalan 2012-05-31 01:05:28 PDT

Created attachment 145011 [details]
Patch

Comment 2 Kenneth Rohde Christiansen 2012-05-31 01:50:02 PDT

Comment on attachment 145011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145011&action=review

> Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:345
>  void QtViewportInteractionEngine::scaleAnimationValueChanged(QVariant value)
>  {
> +    ViewportUpdateDeferrer guard(this);
>      setPageItemRectVisible(value.toRectF());
>  }

This one is not needed... it should be guarded already

Comment 3 zalan 2012-05-31 04:45:37 PDT

(In reply to comment #2)
> (From update of attachment 145011 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145011&action=review
> 
> > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:345
> >  void QtViewportInteractionEngine::scaleAnimationValueChanged(QVariant value)
> >  {
> > +    ViewportUpdateDeferrer guard(this);
> >      setPageItemRectVisible(value.toRectF());
> >  }
> 
> This one is not needed... it should be guarded already

Good catch, but unfortunately it is not guarded. Created a new bug report on that bug#87954

Comment 4 zalan 2012-05-31 05:02:20 PDT

Created attachment 145052 [details]
Patch

Comment 5 WebKit Review Bot 2012-05-31 06:07:51 PDT

Comment on attachment 145052 [details]
Patch

Clearing flags on attachment: 145052

Committed r119095: <http://trac.webkit.org/changeset/119095>

Comment 6 WebKit Review Bot 2012-05-31 06:07:57 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Dinu Jacob 2012-05-31 18:37:30 PDT

*** Bug 88004 has been marked as a duplicate of this bug. ***