Bug 87936 – [Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls.

• Component: WebKit Qt
• Status: RESOLVED FIXED

[zalan]

SSIA

[zalan]

Created attachment 145011 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 145011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145011&action=review

> Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:345
>  void QtViewportInteractionEngine::scaleAnimationValueChanged(QVariant value)
>  {
> +    ViewportUpdateDeferrer guard(this);
>      setPageItemRectVisible(value.toRectF());
>  }

This one is not needed... it should be guarded already

[zalan]

(In reply to comment #2)
> (From update of attachment 145011 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145011&action=review
> 
> > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:345
> >  void QtViewportInteractionEngine::scaleAnimationValueChanged(QVariant value)
> >  {
> > +    ViewportUpdateDeferrer guard(this);
> >      setPageItemRectVisible(value.toRectF());
> >  }
> 
> This one is not needed... it should be guarded already

Good catch, but unfortunately it is not guarded. Created a new bug report on that bug#87954

[zalan]

Created attachment 145052 [details]
Patch

[WebKit Review Bot]

Comment on attachment 145052 [details]
Patch

Clearing flags on attachment: 145052

Committed r119095: <http://trac.webkit.org/changeset/119095>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dinu Jacob]

*** Bug 88004 has been marked as a duplicate of this bug. ***