Bug 87933

Summary:

Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC)

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mitz: review+

Description Andy Estes 2012-05-31 00:39:25 PDT

Guard automatic text replacement code with WTF_USE_AUTOMATIC_TEXT_REPLACEMENT rather than WTF_PLATFORM_MAC

Comment 1 Andy Estes 2012-05-31 00:41:05 PDT

Created attachment 145006 [details]
Patch

Comment 2 Andy Estes 2012-05-31 01:00:10 PDT

Comment on attachment 145006 [details]
Patch

This went too far.

Comment 3 Andy Estes 2012-05-31 13:48:09 PDT

Created attachment 145149 [details]
Patch

Comment 4 mitz 2012-05-31 13:51:47 PDT

Comment on attachment 145149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145149&action=review

> Source/WebCore/ChangeLog:3
> +        Guard automatic text replacement code with WTF_USE_AUTOMATIC_TEXT_REPLACEMENT rather than WTF_PLATFORM_MAC

This doesn’t quite describe what the patch ended up doing.

Comment 5 Andy Estes 2012-05-31 14:03:23 PDT

Committed r119145: <http://trac.webkit.org/changeset/119145>