Bug 87927

Summary: [CMAKE][EFL] Remove unneeded include path
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Gyuyoung Kim 2012-05-30 22:43:33 PDT
Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including previous path. In addition, Files on EFL port is using <wtf/gobject/XXX> directly in #include line. So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.
Comment 1 Gyuyoung Kim 2012-05-30 22:46:33 PDT
Created attachment 144991 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-05-31 02:26:20 PDT
Comment on attachment 144991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144991&action=review

> Source/WebCore/ChangeLog:8
> +        Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including previous

the previous

> Source/WebCore/ChangeLog:9
> +        path. In addition, Files on EFL port is using "<wtf/gobject/XXX>" directly in #include line.

Files *are* ... on the #include line.
Comment 3 Gyuyoung Kim 2012-05-31 02:30:38 PDT
Created attachment 145024 [details]
Patch
Comment 4 WebKit Review Bot 2012-05-31 03:02:31 PDT
Comment on attachment 145024 [details]
Patch

Clearing flags on attachment: 145024

Committed r119080: <http://trac.webkit.org/changeset/119080>
Comment 5 WebKit Review Bot 2012-05-31 03:02:42 PDT
All reviewed patches have been landed.  Closing bug.