Bug 87919

Summary:

[Win] Need implementation of layoutTestController.setBackingScaleFactor

Product:

WebKit

Reporter:

Jessie Berlin <jberlin>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, bfulgham, darin, jberlin, mitz, webkit-bug-importer

Priority:

Keywords:

InRadar, LayoutTestFailure

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Windows 7

Bug Depends on:

Bug Blocks:

146335

Attachments:

Description	Flags
Patch	dino: review+

Description Jessie Berlin 2012-05-30 20:22:38 PDT

It was added as a stub to LayoutTestControllerWin.cpp in http://trac.webkit.org/changeset/97407 and never fleshed out.

In some ways, it would have been better to have omitted the stub on Windows, so it would be more obvious which tests use it and need to be Skipped on Windows

Comment 1 Radar WebKit Bug Importer 2012-05-30 20:23:00 PDT

<rdar://problem/11563242>

Comment 2 Jessie Berlin 2012-05-30 20:30:27 PDT

Added tests to the Windows Skipped list in http://trac.webkit.org/changeset/119039

Comment 3 Brent Fulgham 2015-06-25 18:39:29 PDT

Created attachment 255608 [details]
Patch

Comment 4 Brent Fulgham 2015-06-25 18:59:13 PDT

I'll unskip the tests Jessie skipped back in 2012 once the builders catch up and I can identify any minor differences due to font and other variations with Windows.

Comment 5 Brent Fulgham 2015-06-25 20:56:29 PDT

Committed r185982: <http://trac.webkit.org/changeset/185982>

Comment 6 Brent Fulgham 2015-10-12 12:14:44 PDT

The following tests now work properly:

fast/layers/hidpi-transform-on-child-content-is-mispositioned.html