Bug 87881

Summary: Only include the image checksum error in pretty-diffs for -expected.png files.
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Add another test-case none

Ojan Vafai
Reported 2012-05-30 11:26:43 PDT
Only include the image checksum error in pretty-diffs for -expected.png files.
Attachments
Patch (4.26 KB, patch)
2012-05-30 11:27 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Add another test-case (4.58 KB, patch)
2012-05-30 11:31 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-05-30 11:27:13 PDT
Created attachment 144878 [details] Patch
Ojan Vafai
Comment 2 2012-05-30 11:31:44 PDT
Created attachment 144880 [details] Add another test-case
Dirk Pranke
Comment 3 2012-05-30 13:52:24 PDT
Do we actually have a driver for ruby tests?
Ojan Vafai
Comment 4 2012-05-30 14:25:52 PDT
(In reply to comment #3) > Do we actually have a driver for ruby tests? I don't believe so. I've just be loading the test locally.
WebKit Review Bot
Comment 5 2012-05-30 18:01:32 PDT
Comment on attachment 144880 [details] Add another test-case Clearing flags on attachment: 144880 Committed r119010: <http://trac.webkit.org/changeset/119010>
WebKit Review Bot
Comment 6 2012-05-30 18:01:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.