Bug 87881

Summary:

Only include the image checksum error in pretty-diffs for -expected.png files.

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, eric, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Add another test-case	none

Description Ojan Vafai 2012-05-30 11:26:43 PDT

Only include the image checksum error in pretty-diffs for -expected.png files.

Comment 1 Ojan Vafai 2012-05-30 11:27:13 PDT

Created attachment 144878 [details]
Patch

Comment 2 Ojan Vafai 2012-05-30 11:31:44 PDT

Created attachment 144880 [details]
Add another test-case

Comment 3 Dirk Pranke 2012-05-30 13:52:24 PDT

Do we actually have a driver for ruby tests?

Comment 4 Ojan Vafai 2012-05-30 14:25:52 PDT

(In reply to comment #3)
> Do we actually have a driver for ruby tests?

I don't believe so. I've just be loading the test locally.

Comment 5 WebKit Review Bot 2012-05-30 18:01:32 PDT

Comment on attachment 144880 [details]
Add another test-case

Clearing flags on attachment: 144880

Committed r119010: <http://trac.webkit.org/changeset/119010>

Comment 6 WebKit Review Bot 2012-05-30 18:01:39 PDT

All reviewed patches have been landed.  Closing bug.