Bug 87865

Summary: IndexedDB: Implement IDBTransaction.error and IDBRequest.error
Product: WebKit Reporter: Alec Flett <alecflett>
Component: New BugsAssignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, tony, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 87914    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alec Flett
Reported 2012-05-30 09:55:42 PDT
IndexedDB: Implement IDBTransaction.error and IDBRequest.error
Attachments
Patch (155.57 KB, patch)
2012-05-30 10:05 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (155.67 KB, patch)
2012-05-30 10:12 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (158.04 KB, patch)
2012-05-31 12:23 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2012-05-30 10:05:53 PDT
Created attachment 144850 [details] Patch
WebKit Review Bot
Comment 2 2012-05-30 10:09:41 PDT
Attachment 144850 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/stor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 77 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alec Flett
Comment 3 2012-05-30 10:12:25 PDT
Created attachment 144853 [details] Patch
Alec Flett
Comment 4 2012-05-30 10:56:08 PDT
Comment on attachment 144853 [details] Patch tony@ - r? cq? This builds on yesterday's patch and I have another one following. Most of the patch here is mechanical test updates. Obviously the meat is in the C++, but even that is pretty minor code cleanup.
Alec Flett
Comment 5 2012-05-30 10:56:34 PDT
oops, trying again with tony on the CC: tony@ - r? cq?
WebKit Review Bot
Comment 6 2012-05-30 15:39:45 PDT
Comment on attachment 144853 [details] Patch Clearing flags on attachment: 144853 Committed r118986: <http://trac.webkit.org/changeset/118986>
WebKit Review Bot
Comment 7 2012-05-30 15:39:50 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2012-05-30 18:18:16 PDT
Re-opened since this is blocked by 87914
Alec Flett
Comment 9 2012-05-31 12:23:06 PDT
Created attachment 145131 [details] Patch
Alec Flett
Comment 10 2012-05-31 13:47:53 PDT
Comment on attachment 145131 [details] Patch ok, trying again - the chrome bug revealed a tiny bug in the proxy code (note the change from code() to idbCode() in the chromium/src stuff) and also the test expectations weren't updated for shared workers since they require browser tests to be run. tony@ - r? cq?
WebKit Review Bot
Comment 11 2012-05-31 15:47:52 PDT
Comment on attachment 145131 [details] Patch Clearing flags on attachment: 145131 Committed r119161: <http://trac.webkit.org/changeset/119161>
WebKit Review Bot
Comment 12 2012-05-31 15:47:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.