Bug 87861

Summary: [BlackBerry] Minor string conversion bug
Product: WebKit Reporter: Joe Mason <joenotcharles>
Component: Page LoadingAssignee: Joe Mason <joenotcharles>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Other   
Attachments:
Description Flags
fix
none
fix with changelogs none

Joe Mason
Reported 2012-05-30 09:17:44 PDT
In NetworkJob: username is a WTF::String. ResourceHandleInternal::m_user is a string. Yet they're assigned with "username = m_user.utf8().data()". Pointless: "username = m_user" will do.
Attachments
fix (2.19 KB, patch)
2012-05-30 09:39 PDT, Joe Mason 		no flags
DetailsFormatted DiffDiff
fix with changelogs (3.17 KB, patch)
2012-05-30 10:38 PDT, Joe Mason 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joe Mason
Comment 1 2012-05-30 09:39:36 PDT
Created attachment 144841 [details] fix
Joe Mason
Comment 2 2012-05-30 10:38:53 PDT
Created attachment 144864 [details] fix with changelogs
WebKit Review Bot
Comment 3 2012-05-30 16:07:36 PDT
Comment on attachment 144864 [details] fix with changelogs Clearing flags on attachment: 144864 Committed r118991: <http://trac.webkit.org/changeset/118991>
WebKit Review Bot
Comment 4 2012-05-30 16:07:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.