Bug 87833

Summary: [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch v2 (corrected changelog) none

Mikhail Pozdnyakov
Reported 2012-05-30 01:39:56 PDT
EFL's DRT needs "postProgressFinishedNotification" message in order to unskip http/tests/loading/progress-finished-callback.html
Attachments
patch (2.92 KB, patch)
2012-05-30 01:49 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch v2 (corrected changelog) (2.92 KB, patch)
2012-05-30 02:08 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-05-30 01:49:12 PDT
Created attachment 144753 [details] patch
Gyuyoung Kim
Comment 2 2012-05-30 01:55:38 PDT
Comment on attachment 144753 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=144753&action=review LGTM. > LayoutTests/ChangeLog:3 > + [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message There is two spaces between *needs* and *"post. > Tools/ChangeLog:3 > + [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message ditto.
Mikhail Pozdnyakov
Comment 3 2012-05-30 02:08:07 PDT
Created attachment 144757 [details] patch v2 (corrected changelog)
Mikhail Pozdnyakov
Comment 4 2012-05-30 02:08:39 PDT
(In reply to comment #2) > (From update of attachment 144753 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144753&action=review > > LGTM. > > > LayoutTests/ChangeLog:3 > > + [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message > > There is two spaces between *needs* and *"post. > > > Tools/ChangeLog:3 > > + [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message > > ditto. Thanks. Fixed.
Gyuyoung Kim
Comment 5 2012-05-30 03:02:07 PDT
Comment on attachment 144757 [details] patch v2 (corrected changelog) LGTM.
WebKit Review Bot
Comment 6 2012-05-30 06:55:29 PDT
Comment on attachment 144757 [details] patch v2 (corrected changelog) Clearing flags on attachment: 144757 Committed r118918: <http://trac.webkit.org/changeset/118918>
WebKit Review Bot
Comment 7 2012-05-30 06:55:34 PDT
All reviewed patches have been landed. Closing bug.
Thiago Marcos P. Santos
Comment 8 2012-05-30 08:05:33 PDT
We have this new failure on the bot after this patch landed: http/tests/local/fileapi/file-last-modified-after-delete.html Mikhail, do you mind having a look?
Mikhail Pozdnyakov
Comment 9 2012-05-30 09:32:43 PDT
(In reply to comment #8) > We have this new failure on the bot after this patch landed: > > http/tests/local/fileapi/file-last-modified-after-delete.html > > Mikhail, do you mind having a look? Seems to be unrelated
Note You need to log in before you can comment on or make changes to this bug.