Bug 87820

Summary: [V8][Performance] Optimize DOM attribute getters that return an empty string
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-05-29 21:40:38 PDT
We can optimize the performance of DOM attribute getters that return an empty string (e.g. div.id, div.className, div.title, div.lang ...etc) - by passing Isolate to v8::String::Empty(); and - by inlining V8Binding::getElementStringAttr()
Attachments
Patch (8.00 KB, patch)
2012-05-29 21:48 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-29 21:48:02 PDT
Created attachment 144698 [details] Patch
WebKit Review Bot
Comment 2 2012-05-30 17:30:28 PDT
Comment on attachment 144698 [details] Patch Clearing flags on attachment: 144698 Committed r119004: <http://trac.webkit.org/changeset/119004>
WebKit Review Bot
Comment 3 2012-05-30 17:30:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.