Bug 8782

Summary: use ICU and UChar more, QChar less
Product: WebKit Reporter: Darin Adler <darin>
Component: PlatformAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch that works and passes layout tests; still needs performance testing hyatt: review+

Description Darin Adler 2006-05-07 21:46:55 PDT 
Time to convert WebCore::String and lots of other code to use UChar directly, and cut down QChar use. Soon we can eliminate QChar.
Comment 1 Darin Adler 2006-05-07 22:52:08 PDT 
Created attachment 8160 [details]
patch that works and passes layout tests; still needs performance testing
Comment 2 Dave Hyatt 2006-05-08 11:57:51 PDT 
Comment on attachment 8160 [details]
patch that works and passes layout tests; still needs performance testing

rs=me
Comment 3 Darin Adler 2006-05-08 19:39:29 PDT 
Ironically, we probably want to move to a platform-independent Unicode layer instead of using ICU directly, but that can be a next step.
Comment 4 mitz 2006-05-09 22:23:43 PDT 
The commit included changes to render_style.cpp that didn't appear in the patch and include a typo in RenderStyel::getPseduoStyle. That change is essentially part of the fix for bug 8789, but without the other part, I think this is going to break one of the layout tests.
Comment 5 Timothy Hatcher 2006-05-09 22:54:18 PDT 
Landed in r14273.