Summary: | [GTK] Remove geoclue dependency from WebKit API Layer | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gustavo, mrobinson, philn, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 87800 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Mario Sanchez Prada
2012-05-29 17:58:59 PDT
Created attachment 144665 [details]
Patch proposal
Comment on attachment 144665 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=144665&action=review > Source/WebKit/gtk/GNUmakefile.am:-60 > - $(GEOCLUE_CFLAGS) \ I'm pretty certain you need to keep these flags here. Note that libxslt is on the list. > Source/WebKit/gtk/WebCoreSupport/GeolocationClientGtk.h:62 > + RefPtr<WebCore::GeolocationProviderGeoclue> m_provider; Instead of making this reference-counted and a pointer, it makes more sense, I think, to just make it a member, ie WebCore::GeolocationProvider m_provider; You can then initialize it like this , m_provider(this) Attachment 144665 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/gtk/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 145033 [details]
Patch proposal
New patch, addressing issues raised by Martin
Thansk for the review, Martin. I will push it as soon as I get the dependencies ready too. Note to myself: fix the following typo in this patch when landing: -void GeolocationClient::notifyErrorOcurred(const char* message) +void GeolocationClient::notifyErrorOccurred(const char* message) Committed r119376: <http://trac.webkit.org/changeset/119376> |