Bug 87791

Summary: Show an error in the pretty diff when an image lacks a checksum
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ojan Vafai
Reported 2012-05-29 16:17:56 PDT
Show an error in the pretty diff when an image lacks a checksum
Attachments
Patch (3.65 KB, patch)
2012-05-29 16:18 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-05-29 16:18:24 PDT
Created attachment 144639 [details] Patch
Tony Chang
Comment 2 2012-05-29 17:03:31 PDT
Comment on attachment 144639 [details] Patch Is this only for expected.png files? What if someone is checking in a png, e.g., for the web inspector?
Dirk Pranke
Comment 3 2012-05-29 17:06:29 PDT
(In reply to comment #2) > (From update of attachment 144639 [details]) > Is this only for expected.png files? What if someone is checking in a png, e.g., for the web inspector? bah, good point.
WebKit Review Bot
Comment 4 2012-05-29 19:18:25 PDT
Comment on attachment 144639 [details] Patch Clearing flags on attachment: 144639 Committed r118882: <http://trac.webkit.org/changeset/118882>
WebKit Review Bot
Comment 5 2012-05-29 19:18:30 PDT
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 6 2012-05-29 22:42:04 PDT
It seems PrettyPatch warns whenever a patch adds (not updates) new images.
Ojan Vafai
Comment 7 2012-05-30 09:14:21 PDT
(In reply to comment #6) > It seems PrettyPatch warns whenever a patch adds (not updates) new images. Not sure I understand. Can you point me at a patch/bug where it's doing the wrong thing?
Note You need to log in before you can comment on or make changes to this bug.