Bug 87788

Summary: [chromium] Migrate to WebTransformationMatrix
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Layout and RenderingAssignee: Shawn Singh <shawnsingh>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, dglazkov, fishd, jamesr, tkent+wkapi, vollick, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 87315, 87510    
Bug Blocks:    
Attachments:
Description Flags
for backup, not for review yet
none
Same patch with changelogs jamesr: review+

Shawn Singh
Reported 2012-05-29 15:38:51 PDT
This patch will substitute all instances of WebCore::TransformationMatrix with WebKit::WebTransformationMatrix in the chromium compositor. The change should be completely transparent and incur minimal overhead (specifically, all functions incur one additional trivial wrapper function call on the stack), which will be OK for production, but will that overhead will probably be temporary anyway. This migration is covered by unit tests and layout tests, and should have no change in behavior.
Attachments
for backup, not for review yet (204.51 KB, patch)
2012-05-31 16:35 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
Same patch with changelogs (219.06 KB, patch)
2012-05-31 17:08 PDT, Shawn Singh 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2012-05-31 16:35:52 PDT
Created attachment 145175 [details] for backup, not for review yet This version passes all unit tests, but still need to test it a lot more and add changelogs
Shawn Singh
Comment 2 2012-05-31 17:08:20 PDT
Created attachment 145177 [details] Same patch with changelogs This patch is ready for review. Tested on all unit tests, layout tests, and manually, on mac. This patch does the following: (a) replaced all instances of WebCore::TransformationMatrix with WebKit::WebTransformationMatrix, (b) handled the namespace and other minor fallouts to get things to compile and be clean (c) a few minor cleanups while making things compile (d) adds a new constructor (and unit test) to WebTransformationMatrix
WebKit Review Bot
Comment 3 2012-05-31 17:11:44 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 4 2012-05-31 17:16:10 PDT
Comment on attachment 145177 [details] Same patch with changelogs R=me
James Robinson
Comment 5 2012-05-31 17:24:47 PDT
Committed r119178: <http://trac.webkit.org/changeset/119178>
Note You need to log in before you can comment on or make changes to this bug.