Bug 87780

Summary: [BlackBerry] WebOverlay build fixes and bug fixes
Product: WebKit Reporter: Arvid Nilsson <anilsson>
Component: WebKit BlackBerryAssignee: Arvid Nilsson <anilsson>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Arvid Nilsson 2012-05-29 14:35:51 PDT
Various build fixes for configurations (AC disabled, debug mode) I hadn't tested, and a bug fix due to a typo
Comment 1 Arvid Nilsson 2012-05-29 14:42:09 PDT
Created attachment 144625 [details]
Patch
Comment 2 Arvid Nilsson 2012-05-29 14:49:48 PDT
Reviewed internally by Mike Fenton
Comment 3 Rob Buis 2012-05-29 14:50:59 PDT
Comment on attachment 144625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144625&action=review

> Source/WebKit/blackberry/ChangeLog:1
> +2012-05-29  commit-queue@webkit.org  <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>

The above line seems wrong, please provide a correct author, i.e. you :)
Comment 4 Arvid Nilsson 2012-05-29 15:28:34 PDT
(In reply to comment #3)
> (From update of attachment 144625 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144625&action=review
> 
> > Source/WebKit/blackberry/ChangeLog:1
> > +2012-05-29  commit-queue@webkit.org  <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
> 
> The above line seems wrong, please provide a correct author, i.e. you :)

That's very odd, fixing...
Comment 5 Arvid Nilsson 2012-05-29 15:30:21 PDT
Created attachment 144634 [details]
Patch
Comment 6 Rob Buis 2012-05-29 15:32:30 PDT
Comment on attachment 144634 [details]
Patch

Looks good.
Comment 7 WebKit Review Bot 2012-05-29 16:12:57 PDT
Comment on attachment 144634 [details]
Patch

Clearing flags on attachment: 144634

Committed r118850: <http://trac.webkit.org/changeset/118850>
Comment 8 WebKit Review Bot 2012-05-29 16:13:02 PDT
All reviewed patches have been landed.  Closing bug.