Bug 87780 - [BlackBerry] WebOverlay build fixes and bug fixes
Summary: [BlackBerry] WebOverlay build fixes and bug fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 14:35 PDT by Arvid Nilsson
Modified: 2012-05-29 16:13 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.55 KB, patch)
2012-05-29 14:42 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Patch (5.50 KB, patch)
2012-05-29 15:30 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-05-29 14:35:51 PDT 
Various build fixes for configurations (AC disabled, debug mode) I hadn't tested, and a bug fix due to a typo
Comment 1 Arvid Nilsson 2012-05-29 14:42:09 PDT 
Created attachment 144625 [details]
Patch
Comment 2 Arvid Nilsson 2012-05-29 14:49:48 PDT 
Reviewed internally by Mike Fenton
Comment 3 Rob Buis 2012-05-29 14:50:59 PDT 
Comment on attachment 144625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144625&action=review

> Source/WebKit/blackberry/ChangeLog:1
> +2012-05-29  commit-queue@webkit.org  <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>

The above line seems wrong, please provide a correct author, i.e. you :)
Comment 4 Arvid Nilsson 2012-05-29 15:28:34 PDT 
(In reply to comment #3)
> (From update of attachment 144625 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=144625&action=review
> 
> > Source/WebKit/blackberry/ChangeLog:1
> > +2012-05-29  commit-queue@webkit.org  <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
> 
> The above line seems wrong, please provide a correct author, i.e. you :)

That's very odd, fixing...
Comment 5 Arvid Nilsson 2012-05-29 15:30:21 PDT 
Created attachment 144634 [details]
Patch
Comment 6 Rob Buis 2012-05-29 15:32:30 PDT 
Comment on attachment 144634 [details]
Patch

Looks good.
Comment 7 WebKit Review Bot 2012-05-29 16:12:57 PDT 
Comment on attachment 144634 [details]
Patch

Clearing flags on attachment: 144634

Committed r118850: <http://trac.webkit.org/changeset/118850>
Comment 8 WebKit Review Bot 2012-05-29 16:13:02 PDT 
All reviewed patches have been landed.  Closing bug.