Bug 87762 – TextFieldDecorationElement should respect style attribute

• Component: DOM
• Status: RESOLVED FIXED

[Garrett Casto]

Currently changing the style of a TextFieldDecorationElement does not result in the element rendering any differently. This is because customStyleForRenderer() does not take into account the current styling of the element.

[Garrett Casto]

Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for.

[Kent Tamura]

(In reply to comment #1)
> Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for.

Would you take this please?

I think the customStyleForRenderr() should be:

-    RefPtr<RenderStyle> style = RenderStyle::create();
+    RefPtr<RenderStyle> style = document()->styleResolver()->styleForElement(this);

[Garrett Casto]

(In reply to comment #2)
> (In reply to comment #1)
> > Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for.
> 
> Would you take this please?
> 
> I think the customStyleForRenderr() should be:
> 
> -    RefPtr<RenderStyle> style = RenderStyle::create();
> +    RefPtr<RenderStyle> style = document()->styleResolver()->styleForElement(this);

Got it. I'll see if this works.

[Kent Tamura]

(In reply to comment #2)
> (In reply to comment #1)
> > Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for.
> 
> Would you take this please?
> 
> I think the customStyleForRenderr() should be:
> 
> -    RefPtr<RenderStyle> style = RenderStyle::create();
> +    RefPtr<RenderStyle> style = document()->styleResolver()->styleForElement(this);

Ah, we need to clone it because we modify it.

RefPtr<RenderStyle> originalStyle = document()->styleResolver()->styleForElement(this);
RefPtr<RenderStyle> style = RenderStyle::clone(originalStyle.get());

[Garrett Casto]

Created attachment 144902 [details]
Patch

[Kent Tamura]

Comment on attachment 144902 [details]
Patch

Looks good

[WebKit Review Bot]

Comment on attachment 144902 [details]
Patch

Clearing flags on attachment: 144902

Committed r119020: <http://trac.webkit.org/changeset/119020>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.